Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate and clarify that metadata keys should be strings (backport #11736) #11738

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2024

This is an automatic backport of pull request #11736 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested review from a team as code owners February 7, 2024 17:22
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @t-imamichi

@github-actions github-actions bot added the Changelog: None Do not include in changelog label Feb 7, 2024
@github-actions github-actions bot added this to the 1.0.0 milestone Feb 7, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7818695601

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.004%) to 89.184%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 6 91.18%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 7818124522: -0.004%
Covered Lines: 58806
Relevant Lines: 65938

💛 - Coveralls

@t-imamichi t-imamichi added this pull request to the merge queue Feb 8, 2024
Merged via the queue into stable/1.0 with commit 5913b3d Feb 8, 2024
14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.0/pr-11736 branch February 8, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants