Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduling units (backport #11782) #11817

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 15, 2024

This is an automatic backport of pull request #11782 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fix units

* Add test and reno

* Add support for non-IS units, move test to test_scheduled_circuit.py

* Adapt reno wording

(cherry picked from commit 944e20c)
@mergify mergify bot requested a review from a team as a code owner February 15, 2024 22:25
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Feb 15, 2024
@github-actions github-actions bot added this to the 1.0.1 milestone Feb 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7923092154

Details

  • -1 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 89.27%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/circuit/duration.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.44%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 7921860323: -0.03%
Covered Lines: 58892
Relevant Lines: 65971

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Feb 15, 2024
Merged via the queue into stable/1.0 with commit 5a9a121 Feb 16, 2024
12 of 14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.0/pr-11782 branch February 16, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants