Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom pulse instruction conversion to Qobj. (backport #11829) #11838

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 20, 2024

This is an automatic backport of pull request #11829 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Possible fix.

* Update releasenotes/notes/fix-custom-pulse-qobj-conversion-5d6041b36356cfd1.yaml

Co-authored-by: Will Shanks <wshaos@posteo.net>

* release notes fix

* Add test

---------

Co-authored-by: Will Shanks <wshaos@posteo.net>
(cherry picked from commit 060cb70)
@mergify mergify bot requested a review from a team as a code owner February 20, 2024 04:32
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @nkanazawa1989

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: pulse Related to the Pulse module labels Feb 20, 2024
@github-actions github-actions bot added this to the 1.0.1 milestone Feb 20, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7968499369

Details

  • -1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.008%) to 89.274%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/qobj/converters/pulse_instruction.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 90.68%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 7962954970: 0.008%
Covered Lines: 58894
Relevant Lines: 65970

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Feb 22, 2024
Merged via the queue into stable/1.0 with commit 9387b96 Feb 22, 2024
12 of 14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.0/pr-11829 branch February 22, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: pulse Related to the Pulse module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants