Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed all the transpile calls in test.python.compiler.test_transpiler #11973

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Seed all the transpile calls in test.python.compiler.test_transpiler #11973

merged 1 commit into from
Mar 15, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Mar 8, 2024

to avoid flaky tests, seeding all the transpile calls in test.python.compiler.test_transpiler

@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

@1ucian0 1ucian0 mentioned this pull request Mar 8, 2024
Merged
@jakelishman jakelishman changed the base branch from main to stable/0.46 March 8, 2024 10:39
@kevinhartman kevinhartman changed the base branch from stable/0.46 to main March 8, 2024 17:30
@kevinhartman kevinhartman added the on hold Can not fix yet label Mar 8, 2024
@kevinhartman kevinhartman changed the title [0.46] seeding all the transpile calls in test.python.compiler.test_transpiler Seed all the transpile calls in test.python.compiler.test_transpiler Mar 8, 2024
@kevinhartman kevinhartman force-pushed the 0.46/test.python.compiler.test_transpiler/seed/1 branch from 2c36945 to 3c5f9aa Compare March 8, 2024 17:38
@kevinhartman kevinhartman removed the on hold Can not fix yet label Mar 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8206969361

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.003%) to 89.316%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 4 91.94%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 8190588005: -0.003%
Covered Lines: 59146
Relevant Lines: 66221
💛 - Coveralls

@kevinhartman kevinhartman added Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable labels Mar 15, 2024
@1ucian0
Copy link
Member Author

1ucian0 commented Mar 15, 2024

@Mergifyio backport stable/0.46

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 15, 2024 •
edited
Loading

backport stable/0.46

✅ Backports have been created

kevinhartman
kevinhartman approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@kevinhartman kevinhartman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Even though the random seeding managed to catch a failure during the 0.46.1 release, it's better to have parity between the CI we run on PRs and releases.

@kevinhartman kevinhartman added this pull request to the merge queue Mar 15, 2024
Merged via the queue into Qiskit:main with commit be06208 Mar 15, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Mar 15, 2024
@1ucian0 @mergify
Seed all the transpile calls in test.python.compiler.test_transpiler (#…
9c368ea 
…11973)

(cherry picked from commit be06208)

# Conflicts:
#	test/python/compiler/test_transpiler.py
@mergify mergify bot mentioned this pull request Mar 15, 2024
Merged
mergify bot pushed a commit that referenced this pull request Mar 15, 2024
@1ucian0 @mergify
Seed all the transpile calls in test.python.compiler.test_transpiler (#…
ed8e3e0 
…11973)

(cherry picked from commit be06208)
@mergify mergify bot mentioned this pull request Mar 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 16, 2024
@mergify @1ucian0
Seed all the transpile calls in test.python.compiler.test_transpiler (#…
266da62 
…11973) (#12020)

(cherry picked from commit be06208)

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 24, 2024
@mergify @1ucian0
Seed all the transpile calls in `test.python.compiler.test_transpiler…
5dcfade 
…` (backport #11973) (#12019)

* Seed all the transpile calls in test.python.compiler.test_transpiler (#11973)

(cherry picked from commit be06208)

# Conflicts:
#	test/python/compiler/test_transpiler.py

* conflict solving

---------

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinhartman kevinhartman kevinhartman approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@nonhermitian nonhermitian Awaiting requested review from nonhermitian

@alexanderivrii alexanderivrii Awaiting requested review from alexanderivrii

@ShellyGarion ShellyGarion Awaiting requested review from ShellyGarion

@eggerdj eggerdj Awaiting requested review from eggerdj

@wshanks wshanks Awaiting requested review from wshanks

@ikkoham ikkoham Awaiting requested review from ikkoham

@jyu00 jyu00 Awaiting requested review from jyu00

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@1ucian0 @qiskit-bot @coveralls @kevinhartman @Eric-Arellano