Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mpl circuit drawer with fold=-1 hanging with ControlFlow ops (backport #12016) #12037

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 18, 2024

Summary

Fixes #12012

Details and comments

This PR fixes a hang in the mpl circuit drawer when fold is set to -1 and there are ControlFlow ops in the circuit.


This is an automatic backport of pull request #12016 done by [Mergify](https://mergify.com).

)

* Fix typing-extensions

* Fix control flow with fold minus one

(cherry picked from commit 43381ae)
@mergify mergify bot requested review from nonhermitian and a team as code owners March 18, 2024 18:03
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Mar 18, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8331460176

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.28%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/circuit/matplotlib.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 91.94%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 8315199674: -0.02%
Covered Lines: 58906
Relevant Lines: 65979

💛 - Coveralls

@1ucian0 1ucian0 added this pull request to the merge queue Mar 19, 2024
Merged via the queue into stable/1.0 with commit c9b4687 Mar 19, 2024
14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.0/pr-12016 branch March 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants