Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in soft_compare #12054

Merged
merged 4 commits into from
Mar 24, 2024
Merged

fix typo in soft_compare #12054

merged 4 commits into from
Mar 24, 2024

Conversation

ewinston
Copy link
Contributor

This fixes what appears to be a typo in Instruction.soft_compare.

Summary

This is supposed to return False if the name, number of qubits, number of clbits, or number of parameters are not equal but was ignoring differences in number of qubits and clbits.

Details and comments

@ewinston ewinston requested a review from a team as a code owner March 20, 2024 18:31
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you add a release note to document the fix?

@mtreinish mtreinish added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Mar 20, 2024
@coveralls
Copy link

coveralls commented Mar 21, 2024

Pull Request Test Coverage Report for Build 8411946291

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 94 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.004%) to 89.296%

Files with Coverage Reduction New Missed Lines %
qiskit/synthesis/evolution/lie_trotter.py 2 92.86%
crates/qasm2/src/lex.rs 3 92.62%
qiskit/pulse/parameter_manager.py 9 94.51%
qiskit/transpiler/preset_passmanagers/builtin_plugins.py 12 96.14%
crates/qasm2/src/parse.rs 12 95.77%
qiskit/pulse/schedule.py 56 87.64%
Totals Coverage Status
Change from base Build 8361501008: 0.004%
Covered Lines: 59788
Relevant Lines: 66955

💛 - Coveralls

@1ucian0 1ucian0 enabled auto-merge March 24, 2024 20:32
@1ucian0 1ucian0 added this pull request to the merge queue Mar 24, 2024
Merged via the queue into Qiskit:main with commit 5e7a6d0 Mar 24, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Mar 24, 2024
* fix logic in soft_compare

* black

* add release note

* Update releasenotes/notes/fix_soft_compare-3f4148aab3a4606b.yaml

---------

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
(cherry picked from commit 5e7a6d0)
github-merge-queue bot pushed a commit that referenced this pull request Apr 1, 2024
* fix logic in soft_compare

* black

* add release note

* Update releasenotes/notes/fix_soft_compare-3f4148aab3a4606b.yaml

---------

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
(cherry picked from commit 5e7a6d0)

Co-authored-by: ewinston <ewinston@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants