Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mesage on failed Graphviz optional (backport #11896) #12071

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 24, 2024

Summary

I have recently seen several users struggle to install a complete version of Graphviz upon seeing the MissingOptionalLibraryError message. This updates the message to make it clearer that the PyPI distribution graphviz is not the actual Graphviz software, and it must be installed separately.

Details and comments

Fix #11865, also a couple more messages I've seen on the public Qiskit slack.


This is an automatic backport of pull request #11896 done by [Mergify](https://mergify.com).

* Improve mesage on failed Graphviz optional

I have recently seen several users struggle to install a complete
version of Graphviz upon seeing the `MissingOptionalLibraryError`
message.  This updates the message to make it clearer that the PyPI
distribution `graphviz` *is not* the actual Graphviz software, and it
must be installed separately.

* Tweak message

(cherry picked from commit 17949dc)
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@github-actions github-actions bot added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Mar 24, 2024
@github-actions github-actions bot added this to the 1.1.0 milestone Mar 24, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8412317707

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 86.85%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.35%
crates/qasm2/src/parse.rs 6 97.15%
Totals Coverage Status
Change from base Build 8412034323: 0.01%
Covered Lines: 74988
Relevant Lines: 86342

💛 - Coveralls

@1ucian0 1ucian0 added this pull request to the merge queue Mar 28, 2024
Merged via the queue into stable/0.46 with commit e35b3f0 Mar 28, 2024
12 of 14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.46/pr-11896 branch March 28, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants