Fix GenericBackendV2 duration tests (backport #12136)
#12138
Merged
+17
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Round fallback values and adjust test to rounded values * Remove duplicate key in test dict (cherry picked from commit f76f692)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
jakelishman
approved these changes
Apr 4, 2024
Pull Request Test Coverage Report for Build 8554020325Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two oversights from #11780: applying the rounding to the fallback durations and adjusting the unit tests to the new ranges. I've also added a loop (I guess it could be longer) in the unit test to check more values, given that with random sampling it's not so likely to hit one of the edge values if we only execute it once. I'm not adding a changelog as the changes are contained in the release note of #11780.
Details and comments
Fixes some flaky nightly tests such as: fix-test-ranges
This is an automatic backport of pull request #12136 done by [Mergify](https://mergify.com).