Fix mistaken QPY custom-instructions documentation (backport #12216) #12223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
`num_custom_gates` is not actually part of the `CIRCUIT_HEADER` structs in any version of QPY. The number of custom-instruction objects is instead stored as a `uint64_t` inline in the `CUSTOM_DEFINITIONS` part of the file, so separately to the rest of the header. (cherry picked from commit 5dbc0c0)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
github-actions
bot
added
documentation
jakelishman
approved these changes
Apr 19, 2024
Pull Request Test Coverage Report for Build 8750879017Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
num_custom_gatesis not actually part of theCIRCUIT_HEADERstructs in any version of QPY. The number of custom-instruction objects is instead stored as auint64_tinline in theCUSTOM_DEFINITIONSpart of the file, so separately to the rest of the header.Details and comments
It's always been this way, ever since #5578, and in fact even in the commit within that PR introduced custom gates: 733d32b.
This is an automatic backport of pull request #12216 done by [Mergify](https://mergify.com).