Support standalone Vars in OQ3 exporter
#12308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
Changelog: New Feature
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8916639862Details
💛 - Coveralls |
This was referenced Apr 30, 2024
mtreinish
reviewed
May 1, 2024
There was a problem hiding this comment.
I took a look at the second commit while we wait for #12307 to merge. Overall it looks fine to me, but I'm also not super familiar with the internals of the oq3 exporter so I don't have the most critical eye while looking at this code. I just had some quick questions inline.
This adds the remaining support needed for the OpenQASM 3 exporter to support standalone variables. The way the circuit model handles closures over these variables makes it much easier to support these than it was to handle free-form control-flow operations. This PR somewhat refactors small parts of the exporter to better isolate the "top-level program" statement construction and analysis from the "build a scoped set of instructions" logic, which makes it rather easier to handle things like declaring IO variables only in the global scope, but locally declared variables in _all_ relevant scopes.
mtreinish
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the remaining support needed for the OpenQASM 3 exporter to support standalone variables. The way the circuit model handles closures over these variables makes it much easier to support these than it was to handle free-form control-flow operations.
This PR somewhat refactors small parts of the exporter to better isolate the "top-level program" statement construction and analysis from the "build a scoped set of instructions" logic, which makes it rather easier to handle things like declaring IO variables only in the global scope, but locally declared variables in all relevant scopes.
Details and comments
Close #10929
Depends on #12307 because of the need to decouple the visualisers more from OQ3.