Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1691: Fixed a minor conda env bug in Makefile #1693

Merged
merged 3 commits into from
Jan 21, 2019
Merged

Issue #1691: Fixed a minor conda env bug in Makefile #1693

merged 3 commits into from
Jan 21, 2019

Conversation

jlatone
Copy link
Contributor

@jlatone jlatone commented Jan 17, 2019

Summary

Made the existence test for qiskitenv case-insensitive and the naming of a new Qiskitenv consistent with the documentation (from QISKitenv to Qiskitenv).

Details and comments

See #1691 for details.

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2019

CLA assistant check
All committers have signed the CLA.

@jaygambetta
Copy link
Member

@Latone can you sign the CLA.

@jlatone
Copy link
Contributor Author

jlatone commented Jan 18, 2019

@Latone can you sign the CLA.

I did, several times, not sure why it's not recognized (see image below for verification).

image

@jaygambetta
Copy link
Member

it could be because jaxo added some commits.

@jlatone
Copy link
Contributor Author

jlatone commented Jan 18, 2019

My .gitconfig was pointing to my personal github id not my IBM one at the time I pushed it back to my fork and I didn't notice until I saw the comment thumbnail on the pull...but I am an IBMer and did sign the BCG and I would think that should cover my minor contribution for now. :)

@diego-plan9
Copy link
Member

Seems the CLA was sorted - thanks @jlatone ! For the record, the make env command is a bit stale and not currently referenced in the docs, as it is more flexible to just allow the developer to setup their environment via the tool and particularities of their choosing. Nevertheless, it's a neat fix for reducing the amount of nuisances - thanks!

@diego-plan9 diego-plan9 merged commit abe8362 into Qiskit:master Jan 21, 2019
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* Issue #000: ignore case when testing  conda env exists

* Fixed a minor conda env bug in Makefile (Qiskit#1691).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants