Updating pyenv locally to reduce Travis time #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delapuente
requested review from
1ucian0,
ajavadia,
atilag,
diego-plan9,
ewinston,
jaygambetta,
mtreinish,
nonhermitian and
taalexander
as code owners
|
Numbers with the improvement? |
delapuente
force-pushed
the
reducint-times
branch
3 times, most recently
from
2665d82
to
25cf287
Compare
Most of the time spent on iOS instances came from: * Updating brew so pyenv is able to install the latest Python versions. * Building the Python versions. The patch removes the need of brew by installing pyenv directly. This pyenv is then used to build the three Python interpreters that we support. Now, we cache these builds. Finally we setup the Python environment in the same way we did before the patch. Now the fixing downloads and build the three environments thrice in the worst case (when there is no cache) and updating a Python version, (which is expected for Python 7) requires clearing the cache.
delapuente
force-pushed
the
reducint-times
branch
from
6c809ad
to
00d9768
Compare
|
Around 15 minutes total considering now we test Python 3.5 in MacOS. Should we test Python 3.6 and 3.7 only? @diego-plan9 @1ucian0 ? |
delapuente
changed the title
|
@1ucian0 this is ready. |
diego-plan9
approved these changes
Feb 12, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Aggressively caching pyenv directory. Most of the time spent on iOS instances came from: * Updating brew so pyenv is able to install the latest Python versions. * Building the Python versions. The patch removes the need of brew by installing pyenv directly. This pyenv is then used to build the three Python interpreters that we support. Now, we cache these builds. Finally we setup the Python environment in the same way we did before the patch. Now the fixing downloads and build the three environments thrice in the worst case (when there is no cache) and updating a Python version, (which is expected for Python 7) requires clearing the cache. * Now each version is responsible of the proper Python version * Restoring tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request avoid updating
brewby manually installingpython-build, which is thepyenvplugin in charge of downloading and compiling the Python interpreters. It turns out,python-buildcan be installed standalone. The PR also adds a cache for the interpreter so if it already exists, it is not compiled twice.