Displaying a control gate as a labeled bullet instead of a multibox. #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottwn
requested review from
1ucian0,
ajavadia,
maddy-tod,
mtreinish and
nonhermitian
as code owners
scottwn
changed the title
|
There are some scenarios with problems (pushed tests for them). I think is a vertical compression problem. |
…'master' of github.com:Qiskit/qiskit-terra into issue-4361
|
yeap.. it was a problem with |
1ucian0
approved these changes
May 19, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…iskit#4420) * Fixing multibox logic * Local variable for multibox flag * Add a test * linting * extended test * more testing * yeap.. it was a problem with vertical_compression * lint * lint Co-authored-by: Luciano Bello <luciano.bello@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4361
Details and comments
Added logic to
Bulletplacing the label above or below the wire depending on the position of the bullet.