-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wrapper load_qasm_*
methods to a submodule
#533
Move wrapper load_qasm_*
methods to a submodule
#533
Conversation
Per a discussion with @atilag we agreed on moving these methods again to wrapper but to a different submodule so |
366adbd
to
c0890cb
Compare
c0890cb
to
7c473a1
Compare
For the new files, can you adjust the license header so it follows the format recently introduced by #550 ?
|
7c473a1
to
b85e5de
Compare
@delapuente can you update CHANGELOG.rst accordingly? :) |
…asm-to-quantum-circuit-static-methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @delapuente !
load_qasm_*
methods to a submodule
load_qasm_*
methods to a submoduleload_qasm_*
methods to a submodule
Motivation and Context
It was intended that
load_qasm_string
andload_qasm_file
call static constructors in theQuantumCircuit
instead of being implemented atwrapper
module-level.How Has This Been Tested?
Passing the same test suite without alterations.
Checklist: