Fix Statevector.evolve and DensityMatrix.evolve for mixed dimension subsystems #8900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where Statevector.evolve was reshaping subsystems incorrectly if subsystems had different dimensions.
chriseclectic
added
the
Changelog: Bugfix
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
mtreinish
added
the
stable backport potential
Pull Request Test Coverage Report for Build 3245371185
💛 - Coveralls |
jakelishman
approved these changes
Oct 19, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
…ubsystems (#8900) * Fix bug in OpShape.compose * Fix bug in Statevector.evolve Fixes bug where Statevector.evolve was reshaping subsystems incorrectly if subsystems had different dimensions. * Add additional tests * Add reno * fix reno rst links Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 58d339a)
mergify bot
added a commit
that referenced
this pull request
Oct 20, 2022
…ubsystems (#8900) (#8964) * Fix bug in OpShape.compose * Fix bug in Statevector.evolve Fixes bug where Statevector.evolve was reshaping subsystems incorrectly if subsystems had different dimensions. * Add additional tests * Add reno * fix reno rst links Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 58d339a) Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8897
Fixes #8899
Details and comments
Statevector.evolveandDensityMatrix.evolvewould raise an exeception for nested subsystem evolution for non-qubit subsystems.Statevector.evolvewhere subsystem evolution will return the incorrect value in certain cases where there are 2 or more than non-evolved subsystems with different subsystem dimensions.