Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin tox version in CI #9460

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Pin tox version in CI #9460

merged 1 commit into from
Jan 25, 2023

Conversation

mtreinish
Copy link
Member

Summary

The most recent release tox, 4.4.0, changed the behavior of how tox interacts with constraints files. It is raising an error because it doesn't like the format of our constraints file in qiskit. This commit works around this by pinning our tox version. Given that we're preparing to release 0.23.0 pinning is the fastest solution in the short term, we can adjust things after the release is out.

Details and comments

THe most recent release tox, 4.4.0, changed the behavior of how tox
interacts with constraints files. It is raising an error because it
doesn't like the format of our constraints file in qiskit. This commit
works around this by pinning our tox version. Given that we're preparing
to release 0.23.0 pinning is the fastest solution in the short term, we
can adjust things after the release is out.
@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jan 25, 2023
@mtreinish mtreinish requested a review from a team as a code owner January 25, 2023 21:16
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4010031749

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 84.935%

Files with Coverage Reduction New Missed Lines %
src/sabre_swap/layer.rs 2 98.95%
Totals Coverage Status
Change from base Build 4007457580: 0.03%
Covered Lines: 66703
Relevant Lines: 78534

💛 - Coveralls

Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 85800ca into Qiskit:main Jan 25, 2023
mergify bot pushed a commit that referenced this pull request Jan 25, 2023
THe most recent release tox, 4.4.0, changed the behavior of how tox
interacts with constraints files. It is raising an error because it
doesn't like the format of our constraints file in qiskit. This commit
works around this by pinning our tox version. Given that we're preparing
to release 0.23.0 pinning is the fastest solution in the short term, we
can adjust things after the release is out.

(cherry picked from commit 85800ca)
@mtreinish mtreinish deleted the pin-tox-in-ci branch January 25, 2023 22:27
mergify bot added a commit that referenced this pull request Jan 25, 2023
THe most recent release tox, 4.4.0, changed the behavior of how tox
interacts with constraints files. It is raising an error because it
doesn't like the format of our constraints file in qiskit. This commit
works around this by pinning our tox version. Given that we're preparing
to release 0.23.0 pinning is the fastest solution in the short term, we
can adjust things after the release is out.

(cherry picked from commit 85800ca)

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants