-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin tox version in CI #9460
Pin tox version in CI #9460
Conversation
THe most recent release tox, 4.4.0, changed the behavior of how tox interacts with constraints files. It is raising an error because it doesn't like the format of our constraints file in qiskit. This commit works around this by pinning our tox version. Given that we're preparing to release 0.23.0 pinning is the fastest solution in the short term, we can adjust things after the release is out.
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4010031749
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
THe most recent release tox, 4.4.0, changed the behavior of how tox interacts with constraints files. It is raising an error because it doesn't like the format of our constraints file in qiskit. This commit works around this by pinning our tox version. Given that we're preparing to release 0.23.0 pinning is the fastest solution in the short term, we can adjust things after the release is out. (cherry picked from commit 85800ca)
THe most recent release tox, 4.4.0, changed the behavior of how tox interacts with constraints files. It is raising an error because it doesn't like the format of our constraints file in qiskit. This commit works around this by pinning our tox version. Given that we're preparing to release 0.23.0 pinning is the fastest solution in the short term, we can adjust things after the release is out. (cherry picked from commit 85800ca) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Summary
The most recent release tox, 4.4.0, changed the behavior of how tox interacts with constraints files. It is raising an error because it doesn't like the format of our constraints file in qiskit. This commit works around this by pinning our tox version. Given that we're preparing to release 0.23.0 pinning is the fastest solution in the short term, we can adjust things after the release is out.
Details and comments