Add Migration Guide for qiskit.algorithms
#9557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4616092703
💛 - Coveralls |
woodsp-ibm
added
documentation
woodsp-ibm
reviewed
Mar 10, 2023
| the new Sampler-based :class:`qiskit.algorithms.minimum_eigensolvers.SamplingVQE` algorithm. This could formerly | ||
| be realized using the legacy :class:`~qiskit.algorithms.minimum_eigen_solvers.VQE` with | ||
| :class:`~qiskit.opflow.expectations.CVaRExpectation`. | ||
|
|
There was a problem hiding this comment.
Should we also note the other parameters that have changed. E.g expectation (and include_custom) is gone since its part of Estimator now, gradient is there but its now primitive gradients. max_evals_grouped is gone but can be set directly on an optimizer
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
…it-terra into algos-migration-guide
declanmillar
previously approved these changes
Mar 29, 2023
Co-authored-by: Declan Millar <declan.millar@ibm.com>
woodsp-ibm
reviewed
Mar 30, 2023
|
|
||
| [ 0.01765114+0.0e+00j -0.58507654+0.0e+00j -0.15003642-2.8e-17j] | ||
|
|
||
| For complete code examples, see the following updated tutorials: |
There was a problem hiding this comment.
Minor comment: the output formatting seems to to keep have text closer to the drop down example than the bullet list. Maybe it is what it is. I will note there is only one tutorial in this case - plural is used throughout this even in the case where there is one.
Also its a complete code example only for the new way. There are some tutorials in older versions of the docs out there showing the old way but maybe we are only interested in a fuller example of the new way.
There was a problem hiding this comment.
Yes, I manually added a line break when this happens, I am not sure if it is the best way to handle these kind of formatting issues.
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
…it-terra into algos-migration-guide
Cryoris
approved these changes
Apr 5, 2023
giacomoRanieri
pushed a commit
to giacomoRanieri/qiskit-terra
that referenced
this pull request
Apr 16, 2023
* Add draft * Remove qiskit * Apply review * Add algos guide * Add skeleton * Add content * Fix sampling VQE example * Apply suggestions from Steve's code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Apply review, update code examples up to Eigensolvers * Add doctest to sphinx config * Add tests up to eigensolvers * Review code examples from Eigensolvers * Update heading style * Apply suggestions from Declan's code review Co-authored-by: Declan Millar <declan.millar@ibm.com> * Apply suggestions from Steve's code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Apply review * Final changes, fix docs * Apply Julien's comments --------- Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: Declan Millar <declan.millar@ibm.com>
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
* Add draft * Remove qiskit * Apply review * Add algos guide * Add skeleton * Add content * Fix sampling VQE example * Apply suggestions from Steve's code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Apply review, update code examples up to Eigensolvers * Add doctest to sphinx config * Add tests up to eigensolvers * Review code examples from Eigensolvers * Update heading style * Apply suggestions from Declan's code review Co-authored-by: Declan Millar <declan.millar@ibm.com> * Apply suggestions from Steve's code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Apply review * Final changes, fix docs * Apply Julien's comments --------- Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: Declan Millar <declan.millar@ibm.com>
Eric-Arellano
pushed a commit
to Qiskit/documentation
that referenced
this pull request
Oct 6, 2023
* Add draft * Remove qiskit * Apply review * Add algos guide * Add skeleton * Add content * Fix sampling VQE example * Apply suggestions from Steve's code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Apply review, update code examples up to Eigensolvers * Add doctest to sphinx config * Add tests up to eigensolvers * Review code examples from Eigensolvers * Update heading style * Apply suggestions from Declan's code review Co-authored-by: Declan Millar <declan.millar@ibm.com> * Apply suggestions from Steve's code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Apply review * Final changes, fix docs * Apply Julien's comments --------- Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: Declan Millar <declan.millar@ibm.com>
Eric-Arellano
pushed a commit
to Qiskit/documentation
that referenced
this pull request
Oct 9, 2023
* Add draft * Remove qiskit * Apply review * Add algos guide * Add skeleton * Add content * Fix sampling VQE example * Apply suggestions from Steve's code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Apply review, update code examples up to Eigensolvers * Add doctest to sphinx config * Add tests up to eigensolvers * Review code examples from Eigensolvers * Update heading style * Apply suggestions from Declan's code review Co-authored-by: Declan Millar <declan.millar@ibm.com> * Apply suggestions from Steve's code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Apply review * Final changes, fix docs * Apply Julien's comments --------- Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: Declan Millar <declan.millar@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of algorithms deprecation plan.
Details and comments
Blocked by #9549