Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix qpy import of circuit with StatePreparation #9665

Merged
merged 8 commits into from
Mar 2, 2023
Merged

Fix qpy import of circuit with StatePreparation #9665

merged 8 commits into from
Mar 2, 2023

Conversation

king-p3nguin
Copy link
Contributor

Summary

Details and comments

@king-p3nguin king-p3nguin requested a review from a team as a code owner February 25, 2023 19:29
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Feb 25, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@king-p3nguin king-p3nguin changed the title Pr fix import state preparation Fix qpy import of circuit with StatePreparation Feb 25, 2023
@coveralls
Copy link

coveralls commented Feb 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4318145129

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 85.341%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 94.93%
Totals Coverage Status
Change from base Build 4309626206: -0.001%
Covered Lines: 67529
Relevant Lines: 79128
💛 - Coveralls

jakelishman
jakelishman reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Please could you also add a test of this in test/python/circuit/test_circuit_load_from_qpy.py - there's a similar-ish test on line 596 called test_initialize that it can go near.

@king-p3nguin
Copy link
Contributor Author

Thank you for the review! I added a new test.

jakelishman
jakelishman approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ace, thanks for the test and the fix!

@jakelishman jakelishman added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog automerge mod: qpy Related to QPY serialization labels Mar 2, 2023
@jakelishman jakelishman added this to the 0.23.3 milestone Mar 2, 2023
@1ucian0
Copy link
Member

1ucian0 commented Mar 2, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2023

refresh

✅ Pull request refreshed

@1ucian0 1ucian0 closed this Mar 2, 2023
@1ucian0 1ucian0 reopened this Mar 2, 2023
@mergify mergify bot merged commit dc1737c into Qiskit:main Mar 2, 2023
mergify bot pushed a commit that referenced this pull request Mar 2, 2023
@king-p3nguin @mergify
Fix qpy import of circuit with StatePreparation (#9665)
f57f541 
* add StatePreparation to list

* add reno

* add test

* fix lint

* Reword release note

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit dc1737c)
@mergify mergify bot mentioned this pull request Mar 2, 2023
Merged
mergify bot added a commit that referenced this pull request Mar 2, 2023
@mergify @king-p3nguin
Fix qpy import of circuit with StatePreparation (#9665) (#9711)
ac9f9b9 
* add StatePreparation to list

* add reno

* add test

* fix lint

* Reword release note

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit dc1737c)

Co-authored-by: Kazuki Tsuoka <kazukitsuoka@g.ecc.u-tokyo.ac.jp>
@king-p3nguin king-p3nguin deleted the pr-fix-import-StatePreparation branch March 3, 2023 06:03
This was referenced May 3, 2023
Merged
Merged
king-p3nguin added a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
@king-p3nguin @jakelishman @mergify
Fix qpy import of circuit with StatePreparation (Qiskit#9665)
f11826a 
* add StatePreparation to list

* add reno

* add test

* fix lint

* Reword release note

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: qpy Related to QPY serialization stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Contributor Monitoring
Status: Done
Milestone
0.23.3
Development

Successfully merging this pull request may close these issues.

qpy import of circuit with StatePreparation fails
5 participants
@king-p3nguin @qiskit-bot @coveralls @1ucian0 @jakelishman