-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix method theme #146
Fix method theme #146
Conversation
@1ucian0 @javabster This PR is ready for review/comments :) |
@karlaspuldaro Thanks for your contribution! This looks great! I will review your PR soon. |
This looks great to me, thanks so much @karlaspuldaro! To answer your questions:
|
@javabster Thank you for reviewing! I believe all comments have been addressed, and I've created a new issue to track the follow up idea of adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @karlaspuldaro 🚀
Fixes #45
This PR fixes the
methods
level rendering to matchfunctions
style.CSS selector was not picking up correct element with targeted method class.(this was one problem but it did not fully matchfunctions
theme style)method
andstatic method
html class to be consistent withfunctions
styling themeCompared to functions theme rendering:
Follow up on separate PR:
methods.rst
example underdocs/sphinx-guide/