Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing musl skip for ppc64le builds #1109

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

mtreinish
Copy link
Member

This commit fixes an issue in the ppc64le wheel builds. One of the two ppc64le wheel build jobs was incorrectly attempting to build wheels for musl environments which isn't a supported platform and the jobs failed to configure. This commit just adds the missing skip for those environments to the job configuration to fix this issue.

This commit fixes an issue in the ppc64le wheel builds. One of the two
ppc64le wheel build jobs was incorrectly attempting to build wheels for
musl environments which isn't a supported platform and the jobs failed
to configure. This commit just adds the missing skip for those
environments to the job configuration to fix this issue.
@mtreinish mtreinish added the stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch label Feb 22, 2024
@coveralls
Copy link

coveralls commented Feb 22, 2024

Pull Request Test Coverage Report for Build 8005147455

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 96.483%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_bellman_ford.rs 6 95.53%
Totals Coverage Status
Change from base Build 8004684491: -0.03%
Covered Lines: 16815
Relevant Lines: 17428

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this should work as I tested it in #1064

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Feb 22, 2024
@mergify mergify bot merged commit f4f1212 into Qiskit:main Feb 22, 2024
30 checks passed
mergify bot pushed a commit that referenced this pull request Feb 22, 2024
This commit fixes an issue in the ppc64le wheel builds. One of the two
ppc64le wheel build jobs was incorrectly attempting to build wheels for
musl environments which isn't a supported platform and the jobs failed
to configure. This commit just adds the missing skip for those
environments to the job configuration to fix this issue.

Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
(cherry picked from commit f4f1212)
mtreinish added a commit to mtreinish/retworkx that referenced this pull request Feb 22, 2024
This commit prepares for a 0.14.1 release which just includes Qiskit#1109 to
fix ppc64le builds and Qiskit#1096 to fix the overhead of `__getitem__` on
custom sequence return types.
mergify bot added a commit that referenced this pull request Feb 22, 2024
This commit fixes an issue in the ppc64le wheel builds. One of the two
ppc64le wheel build jobs was incorrectly attempting to build wheels for
musl environments which isn't a supported platform and the jobs failed
to configure. This commit just adds the missing skip for those
environments to the job configuration to fix this issue.

Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
(cherry picked from commit f4f1212)

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish added a commit that referenced this pull request Feb 22, 2024
* Prepare 0.14.1 release

This commit prepares for a 0.14.1 release which just includes #1109 to
fix ppc64le builds and #1096 to fix the overhead of `__getitem__` on
custom sequence return types.

* Update releasenotes/notes/prepare-0.14.1-e5065553a44eb035.yaml

Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>

* Update version in docs config too

---------

Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants