Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hint for search functions #1132

Merged
merged 3 commits into from Mar 4, 2024
Merged

Fix type hint for search functions #1132

merged 3 commits into from Mar 4, 2024

Conversation

JPena-code
Copy link
Contributor

Aims to fix the mismatchof the type hint for the search functions bfs_search, dfs_search and dijkstra_search #1130

  • I ran rustfmt locally
  • I have added the tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Mar 4, 2024 •
edited

Pull Request Test Coverage Report for Build 8146691700

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.467%
Totals Coverage Status
Change from base Build 8141406179: 0.0%
Covered Lines: 17095
Relevant Lines: 17721
💛 - Coveralls

@IvanIsCoding
Copy link
Collaborator

Can you rebase your PR to only include your changes? Currently you are including changes from #1103 which makes it difficult to review

@JPena-code
Copy link
Contributor Author

Of course

IvanIsCoding
IvanIsCoding approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@IvanIsCoding IvanIsCoding merged commit de6684f into Qiskit:main Mar 4, 2024
28 checks passed
@IvanIsCoding
Copy link
Collaborator

@Mergifyio backport stable/0.14

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 4, 2024 •
edited

backport stable/0.14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 4, 2024
@JPena-code @mergify
Fix type hint for search functions (#1132)
0ee503b 
* Fix type hint for search functions

* Revert import order

---------

Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
(cherry picked from commit de6684f)
@mergify mergify bot mentioned this pull request Mar 4, 2024
Merged
mergify bot added a commit that referenced this pull request Mar 4, 2024
@mergify @JPena-code
Fix type hint for search functions (#1132) (#1133)
d28e5d4 
* Fix type hint for search functions

* Revert import order

---------

Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
(cherry picked from commit de6684f)

Co-authored-by: Julio Quintero <julioquintetro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanIsCoding IvanIsCoding IvanIsCoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JPena-code @CLAassistant @coveralls @IvanIsCoding