Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return a cycle in digraph_find_cycle if no node is specified and a cycle exists #1181

Merged
merged 21 commits into from
May 16, 2024
Merged

Always return a cycle in digraph_find_cycle if no node is specified and a cycle exists #1181

merged 21 commits into from
May 16, 2024

Commits on Apr 29, 2024

  1. Handle find arbitrary cycle case

    @IvanIsCoding
    IvanIsCoding committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    382f526 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into find-arbitrary-cycle

    @IvanIsCoding
    IvanIsCoding committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    89fd5c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge remote-tracking branch 'upstream/main' into find-arbitrary-cycle

    @IvanIsCoding
    IvanIsCoding committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ac32827 View commit details
    Browse the repository at this point in the history

  2. Find node in cycle more smartly

    @IvanIsCoding
    IvanIsCoding committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ac9318d View commit details
    Browse the repository at this point in the history

  3. Implement find_node_in_arbitrary_cycle

    @IvanIsCoding
    IvanIsCoding committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    69565ca View commit details
    Browse the repository at this point in the history

  4. Switch to Tarjan SCC for single pass DFS

    @IvanIsCoding
    IvanIsCoding committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    562bd29 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Improve cycle checking logic

    @IvanIsCoding
    IvanIsCoding committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0def100 View commit details
    Browse the repository at this point in the history

  2. More assert_cycle!

    @IvanIsCoding
    IvanIsCoding committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d8788a9 View commit details
    Browse the repository at this point in the history

  3. Cargo fmt

    @IvanIsCoding
    IvanIsCoding committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a6790cd View commit details
    Browse the repository at this point in the history

  4. Add test case for no cycle and no source

    @IvanIsCoding
    IvanIsCoding committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2346745 View commit details
    Browse the repository at this point in the history

  5. assertCycle for existing unit tests

    @IvanIsCoding
    IvanIsCoding committed May 1, 2024
    Configuration menu
    Copy the full SHA
    838a9d1 View commit details
    Browse the repository at this point in the history

  6. Add more tests

    @IvanIsCoding
    IvanIsCoding committed May 1, 2024
    Configuration menu
    Copy the full SHA
    080edcc View commit details
    Browse the repository at this point in the history

  7. Add self loop Python test

    @IvanIsCoding
    IvanIsCoding committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b56b05d View commit details
    Browse the repository at this point in the history

  8. Add release notes and fix test

    @IvanIsCoding
    IvanIsCoding committed May 1, 2024
    Configuration menu
    Copy the full SHA
    98e62f4 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Merge branch 'main' into find-arbitrary-cycle

    @IvanIsCoding
    IvanIsCoding committed May 3, 2024
    Configuration menu
    Copy the full SHA
    86a24b7 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'main' into find-arbitrary-cycle

    @IvanIsCoding
    IvanIsCoding committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e4cdfeb View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Address PR comments

    @IvanIsCoding
    IvanIsCoding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3260048 View commit details
    Browse the repository at this point in the history

  2. Use less traits

    @IvanIsCoding
    IvanIsCoding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    4885358 View commit details
    Browse the repository at this point in the history

  3. Update release notes

    @IvanIsCoding
    IvanIsCoding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9fd9e04 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into find-arbitrary-cycle

    @IvanIsCoding
    IvanIsCoding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    208bcb4 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Merge branch 'main' into find-arbitrary-cycle

    @mergify
    mergify[bot] committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d25903c View commit details
    Browse the repository at this point in the history