Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ipykernel and jupyter-client packages #844

Closed
wants to merge 1 commit into from

Conversation

mtreinish
Copy link
Member

With the recent release of ipykernel 6.22.0 and jupyter-client 8.1.0 our docs builds are failing to run, it fails on processing the first jupyter-execute directive as it's unable to launch a jupyter kernel. This commit pins these packages in the constraints file (as we don't directly depend on them) to the last known working version to unblock CI.

With the recent release of ipykernel 6.22.0 and jupyter-client 8.1.0 our
docs builds are failing to run, it fails on processing the first
jupyter-execute directive as it's unable to launch a jupyter kernel.
This commit pins these packages in the constraints file (as we don't
directly depend on them) to the last known working version to unblock
CI.
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably investifate it further, but let's unblock the CI first

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Mar 22, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4492544513

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 97.083%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_dijkstra.rs 2 98.54%
Totals Coverage Status
Change from base Build 4475309435: -0.007%
Covered Lines: 14046
Relevant Lines: 14468

💛 - Coveralls

@IvanIsCoding
Copy link
Collaborator

Apparently the documentation build is still failing? It didn’t find the Python3 kernel

@IvanIsCoding IvanIsCoding self-requested a review March 22, 2023 22:06
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be related to jupyter/jupyter-sphinx#222?

I think it might be worth trying to create a Python3 alias/mock kernel to help jupyter-sphinx while the library fixes it?

@mtreinish
Copy link
Member Author

Superseded by #845

@mtreinish mtreinish closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants