Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install and use of Jupyter Kernel for docs #845

Merged
merged 6 commits into from
Mar 23, 2023

Conversation

IvanIsCoding
Copy link
Collaborator

@IvanIsCoding IvanIsCoding commented Mar 22, 2023

Tries to fix the same problem as #844 but without pinning

For some reason the python3 kernel stopped being installed togethe with Jupyter, hence:

  • we install the kernel on the tox environment
  • we explicity use the kernel in the Sphinx configuration

@coveralls
Copy link

coveralls commented Mar 22, 2023

Pull Request Test Coverage Report for Build 4496904050

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 97.114%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_bellman_ford.rs 1 98.88%
Totals Coverage Status
Change from base Build 4475309435: 0.02%
Covered Lines: 13896
Relevant Lines: 14309

💛 - Coveralls

@IvanIsCoding IvanIsCoding changed the title [WIP] Specify Jupyter kernel name for docs build Fix install and use of Jupyter Kernel for docs Mar 23, 2023
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this for real, my eager pinning wasn't sufficient. I'm a bit surprised that we need to manually install ipykernel I'm guessing it was getting pulled in transitively by something before and a package was missing it in its requirements list. But since this is passing CI it should be good to go.

@@ -9,3 +9,4 @@ qiskit-sphinx-theme>=1.7
matplotlib>=3.4
sphinx-reredirects
sphinxemoji
ipykernel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite surprised this isn't getting pulled in anymore. I would expect jupyter-sphinx to end up pulling this in.

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Mar 23, 2023
@mergify mergify bot merged commit de75534 into Qiskit:main Mar 23, 2023
@IvanIsCoding IvanIsCoding deleted the fix-jupyter-errors branch March 23, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants