Shortern boilerplate for singledispatch
#882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIsCoding
changed the title
singledispatchsingledispatch
Pull Request Test Coverage Report for Build 6025476956
💛 - Coveralls |
IvanIsCoding
force-pushed
the
shorter-dispatch
branch
from
7e89202
to
629d345
Compare
mtreinish
approved these changes
Aug 30, 2023
| @@ -249,7 +249,9 @@ pub fn digraph_random_layout( | |||
| /// :returns: The bipartite layout of the graph. | |||
| /// :rtype: Pos2DMapping | |||
| #[pyfunction] | |||
| #[pyo3(text_signature = "(graph, first_nodes, /, horitontal=False, scale=1, | |||
| #[pyo3( | |||
| signature=(graph, first_nodes, horizontal=false, scale=1.0, center=None, aspect_ratio=1.33333333333333), | |||
There was a problem hiding this comment.
This is a good catch on the defaults not matching
mtreinish
pushed a commit
that referenced
this pull request
Feb 22, 2024
Follow up of #882, albeit more agressive on shortening the boilerplate amount of code for universal functions This PR introduces a new _rustworkx_dispatch decorator that: * Creates the singledispatch for func * Automatically registers digraph_func for PyDiGraph * Automatically registers graph_func for PyGraph The decorator is based on the original functools.singledispatch. It should simplify the amount of code we need to write an universal function. It does add a little bit of "magic" with functools and importlib, but overall it should be maintainable * Try to shorten Bellman-Ford * More shortening * Even more * Almost done with shortening * Finish shortening * Fix layout incorrect default arguments * Simplify distance_matrix * Magic custom dispatcher * Minor detail about is_isomorphic_node_match * Black * Use explicit package name * Minor change * Sync with main * Black * Minor fix * Sync with new functions * Synch with new functions * Fix cargo lock * Cargo.lock strikes again * Fix black error * Black fmt * Do not explicitly export rustworkx_dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortern boilerplate code for
singledispatch. This is convenient becase we don't need repeat the function signaturenote: for after 0.13 release