Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

feat(ui-shell): update Documentation nav menu #235

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

techtolentino
Copy link
Collaborator

Changes

Closes Qiskit/qiskit.org#3169

Implementation details

  • removes Documentation as a mega menu nav item
  • updates Documentation child links to follow URL defined here
  • makes small spacing update in mobile menu

How to read this PR

  • please review Documentation nav child items
  • review deleted code associated with the nav megaMenu

Screenshots

Screen.Recording.2023-07-21.at.12.06.21.PM.mov

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

🦋 Changeset detected

Latest commit: 9d67db9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@qiskit/web-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you

@eddybrando eddybrando self-requested a review July 25, 2023 12:44
Copy link
Contributor

@eddybrando eddybrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @techtolentino!

Just one comment, since I don't understand why the padding change was done here.

components/ui-shell/index.scss Show resolved Hide resolved
@y4izus y4izus merged commit 21f9a3c into main Jul 25, 2023
8 checks passed
@y4izus y4izus deleted the feat/ui-shell-update-docs-menu branch July 25, 2023 14:46
Eric-Arellano added a commit to Qiskit/qiskit_sphinx_theme that referenced this pull request Jul 25, 2023
Applies Qiskit/web-components#235. This removes
the Applications from the top nav bar.
Eric-Arellano added a commit to Eric-Arellano/qiskit_sphinx_theme that referenced this pull request Jul 25, 2023
Applies Qiskit/web-components#235. This removes
the Applications from the top nav bar.
Eric-Arellano added a commit to Eric-Arellano/qiskit_sphinx_theme that referenced this pull request Jul 25, 2023
Applies Qiskit/web-components#235. This removes
the Applications from the top nav bar.
Eric-Arellano added a commit to Qiskit/qiskit_sphinx_theme that referenced this pull request Jul 25, 2023
… (#524)

Applies Qiskit/web-components#235. This removes
the Applications from the top nav bar.
Eric-Arellano added a commit to Qiskit/qiskit_sphinx_theme that referenced this pull request Jul 25, 2023
… (#523)

Applies Qiskit/web-components#235. This removes
the Applications from the top nav bar.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants