Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionCreator and ConnectionAcceptor don't shutdown smoothly #98

Closed
catbref opened this issue Jun 13, 2018 · 1 comment
Closed

ConnectionCreator and ConnectionAcceptor don't shutdown smoothly #98

catbref opened this issue Jun 13, 2018 · 1 comment
Labels
bug can reproduce fix working? Waiting for reports that fix works

Comments

@catbref
Copy link
Collaborator

catbref commented Jun 13, 2018

On shutdown the ConnectionCreator doesn't exit swiftly and users might see this error message:

Exception in thread "Thread-24" java.lang.IllegalAccessError: DB has been closed
        at org.mapdb.EngineWrapper.checkClosed(EngineWrapper.java:155)
        at org.mapdb.Caches$HashTable.get(Caches.java:238)
        at org.mapdb.BTreeMap.get(BTreeMap.java:595)
        at org.mapdb.BTreeMap.containsKey(BTreeMap.java:1506)
        at database.PeerMap.getInfo(PeerMap.java:419)
        at database.PeerMap.isBlacklisted(PeerMap.java:427)
        at network.PeerManager.isBlacklisted(PeerManager.java:71)
        at network.ConnectionCreator.run(ConnectionCreator.java:102)

In addition, there doesn't seem to be any short-cut exit in ConnectionAcceptor if a new connection arrives during shutdown.
catbref added a commit that referenced this issue Jun 13, 2018
@catbref
Merge pull request #99 from catbref/master
28474b1 
PR with fixes for issue #97 and issue #98 and version bump
@catbref catbref added the fix working? Waiting for reports that fix works label Jun 13, 2018
@catbref
Copy link
Collaborator Author

catbref commented Jun 13, 2018

Should be fixed in v0.26.10

@catbref catbref closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug can reproduce fix working? Waiting for reports that fix works
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@catbref