Skip to content

Commit

Permalink
Ensure analyzers are defined as PrivateAssets.
Browse files Browse the repository at this point in the history
  • Loading branch information
Corniel committed Jul 31, 2023
1 parent 4bc04dc commit 15286a1
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 17 deletions.
4 changes: 2 additions & 2 deletions props/common.props
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
</ItemGroup>

<ItemGroup Label="Analyzers">
<PackageReference Include="AsyncFixer" Version="*" />
<PackageReference Include="DotNetProjectFile.Analyzers" Version="*" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<PackageReference Include="AsyncFixer" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<PackageReference Include="DotNetProjectFile.Analyzers" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
</ItemGroup>

Expand Down
39 changes: 26 additions & 13 deletions specs/Qowaiv.Specs/NuGet_packages_specs.cs
Original file line number Diff line number Diff line change
@@ -1,20 +1,33 @@
namespace NuGet_packages_specs
namespace NuGet_packages_specs;

public class All_NuGet_Packages
{
public class All_NuGet_Packages
[TestCaseSource(nameof(Packages))]
public void Are_signed(Assembly package)
=> package.Should().HavePublicKey(
"0024000004800000940000000602000000240000525341310004000001000100EF35DF58AA7FEC73A11E70572E6B3791601006EF3FB1C6C1F1A402BA83BB2EDC975C61E8A32D792EDB864127F0D2C67EB7A64A9D3A0CDB0B1BB37FF2D0FCFD7990304623C044439D04DAC49624CC6D7937581419D995C2689F9898EC09C941B3EB3CAB8E4FC8F90B4AE5D45AB03D691D4D1F4B68450DAD41FED46671376934B0");

[TestCaseSource(nameof(Packages))]
public void x(Assembly package)
{
[TestCaseSource(nameof(Packages))]
public void Are_signed(Assembly package)
=> package.Should().HavePublicKey(
"0024000004800000940000000602000000240000525341310004000001000100EF35DF58AA7FEC73A11E70572E6B3791601006EF3FB1C6C1F1A402BA83BB2EDC975C61E8A32D792EDB864127F0D2C67EB7A64A9D3A0CDB0B1BB37FF2D0FCFD7990304623C044439D04DAC49624CC6D7937581419D995C2689F9898EC09C941B3EB3CAB8E4FC8F90B4AE5D45AB03D691D4D1F4B68450DAD41FED46671376934B0");
var references = package.GetReferencedAssemblies();

foreach(var reference in references)
{
Console.WriteLine(reference);
}

private static IEnumerable<Assembly> Packages
references.Should().BeEmpty();
}


private static IEnumerable<Assembly> Packages
{
get
{
get
{
yield return typeof(Qowaiv.SingleValueObjectAttribute).Assembly;
yield return typeof(Qowaiv.Data.SvoParameter).Assembly;
yield return typeof(Qowaiv.TestTools.JsonTester).Assembly;
}
yield return typeof(Qowaiv.SingleValueObjectAttribute).Assembly;
yield return typeof(Qowaiv.Data.SvoParameter).Assembly;
yield return typeof(Qowaiv.TestTools.JsonTester).Assembly;
}
}
}
4 changes: 2 additions & 2 deletions specs/Qowaiv.Specs/Qowaiv.Specs.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
</ItemGroup>

<ItemGroup Label="Analyzers">
<PackageReference Include="FluentAssertions.Analyzers" Version="*" />
<PackageReference Include="NUnit.Analyzers" Version="*" />
<PackageReference Include="FluentAssertions.Analyzers" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<PackageReference Include="NUnit.Analyzers" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
</ItemGroup>

<ItemGroup>
Expand Down

0 comments on commit 15286a1

Please sign in to comment.