Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BackwardsCompatibleFeatures package to simplify build #310

Merged
merged 4 commits into from
May 9, 2023
Merged

Use BackwardsCompatibleFeatures package to simplify build #310

merged 4 commits into from
May 9, 2023

Conversation

Corniel
Copy link
Collaborator

@Corniel Corniel commented May 8, 2023

As BackwardsCompatibleFeatures reduces the need to some #if code blocks. More details can be found here.

@Corniel Corniel self-assigned this May 8, 2023
CptWesley
CptWesley approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@CptWesley CptWesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Corniel Corniel merged commit 89d3198 into master May 9, 2023
@Corniel Corniel deleted the backwards-compatible branch May 9, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CptWesley CptWesley CptWesley approved these changes

Assignees

@Corniel Corniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Corniel @CptWesley