Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzers should not be included in NuGet packages #322

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Analyzers should not be included in NuGet packages #322

merged 4 commits into from
Jul 31, 2023

Conversation

Corniel
Copy link
Collaborator

@Corniel Corniel commented Jul 31, 2023

By cleaning-up the props, two analyzers where not longer marked as PrivateAssets.

See: #321

@Corniel Corniel added the bug label Jul 31, 2023
@Corniel Corniel requested a review from Sjaaky July 31, 2023 14:09
@Corniel Corniel self-assigned this Jul 31, 2023
Sjaaky
Sjaaky approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@Sjaaky Sjaaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Corniel Corniel merged commit 739e7fd into master Jul 31, 2023
2 checks passed
@Corniel Corniel deleted the analyzers-private branch July 31, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sjaaky Sjaaky Sjaaky approved these changes

Assignees

@Corniel Corniel

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Corniel @Sjaaky