Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzers should not be included in NuGet packages #322

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Analyzers should not be included in NuGet packages #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15286a1
Ensure analyzers are defined as PrivateAssets.
Corniel Jul 31, 2023
67ac1d9
Prepare release.
Corniel Jul 31, 2023
e57e6c7
boy-scout.
Corniel Jul 31, 2023
a7b955b
Fix test.
Corniel Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions props/common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
</ItemGroup>

<ItemGroup Label="Analyzers">
<PackageReference Include="AsyncFixer" Version="*" />
<PackageReference Include="DotNetProjectFile.Analyzers" Version="*" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<PackageReference Include="AsyncFixer" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<PackageReference Include="DotNetProjectFile.Analyzers" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
</ItemGroup>

Expand Down
27 changes: 13 additions & 14 deletions specs/Qowaiv.Specs/NuGet_packages_specs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
namespace NuGet_packages_specs
namespace NuGet_packages_specs;

public class All_NuGet_Packages
{
public class All_NuGet_Packages
{
[TestCaseSource(nameof(Packages))]
public void Are_signed(Assembly package)
=> package.Should().HavePublicKey(
"0024000004800000940000000602000000240000525341310004000001000100EF35DF58AA7FEC73A11E70572E6B3791601006EF3FB1C6C1F1A402BA83BB2EDC975C61E8A32D792EDB864127F0D2C67EB7A64A9D3A0CDB0B1BB37FF2D0FCFD7990304623C044439D04DAC49624CC6D7937581419D995C2689F9898EC09C941B3EB3CAB8E4FC8F90B4AE5D45AB03D691D4D1F4B68450DAD41FED46671376934B0");
[TestCaseSource(nameof(Packages))]
public void Are_signed(Assembly package)
=> package.Should().HavePublicKey(
"0024000004800000940000000602000000240000525341310004000001000100EF35DF58AA7FEC73A11E70572E6B3791601006EF3FB1C6C1F1A402BA83BB2EDC975C61E8A32D792EDB864127F0D2C67EB7A64A9D3A0CDB0B1BB37FF2D0FCFD7990304623C044439D04DAC49624CC6D7937581419D995C2689F9898EC09C941B3EB3CAB8E4FC8F90B4AE5D45AB03D691D4D1F4B68450DAD41FED46671376934B0");

private static IEnumerable<Assembly> Packages
private static IEnumerable<Assembly> Packages
{
get
{
get
{
yield return typeof(Qowaiv.SingleValueObjectAttribute).Assembly;
yield return typeof(Qowaiv.Data.SvoParameter).Assembly;
yield return typeof(Qowaiv.TestTools.JsonTester).Assembly;
}
yield return typeof(Qowaiv.SingleValueObjectAttribute).Assembly;
yield return typeof(Qowaiv.Data.SvoParameter).Assembly;
yield return typeof(Qowaiv.TestTools.JsonTester).Assembly;
}
}
}
4 changes: 2 additions & 2 deletions specs/Qowaiv.Specs/Qowaiv.Specs.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
</ItemGroup>

<ItemGroup Label="Analyzers">
<PackageReference Include="FluentAssertions.Analyzers" Version="*" />
<PackageReference Include="NUnit.Analyzers" Version="*" />
<PackageReference Include="FluentAssertions.Analyzers" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<PackageReference Include="NUnit.Analyzers" Version="*" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion specs/Qowaiv.Specs/TestTools/XML_structure_specs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ public class With_debugger_experience
{
[Test]
public void via_ToString()
=> XmlStructure.New(true).ToString().Should().Be("ID: 17, SVO: True, Date: 2017-06-11T00:00:00.0000000");
=> XmlStructure.New(true).ToString().Should().Be("ID: 17, SVO: True, Date: 2017-06-11T00:00:00.0000000Z");
}
2 changes: 1 addition & 1 deletion src/Qowaiv.TestTools/XmlStructure.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public sealed class XmlStructure<TSvo>
public TSvo Svo { get; set; }

/// <summary>Gets and sets a date (time) property.</summary>
public DateTime Date { get; set; } = new DateTime(2017, 06, 11, 00, 00, 000, DateTimeKind.Local);
public DateTime Date { get; set; } = new DateTime(2017, 06, 11, 00, 00, 000, DateTimeKind.Utc);

/// <inheritdoc />
[Pure]
Expand Down
4 changes: 3 additions & 1 deletion src/Qowaiv/Qowaiv.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@
<PropertyGroup>
<TargetFrameworks>netstandard2.0;net5.0;net6.0;net7.0</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Version>6.4.2</Version>
<Version>6.4.3</Version>
<PackageId>Qowaiv</PackageId>
<PackageReleaseNotes>
v6.4.3
- Analyzers should not be included in NuGet packages. #321 (fix)
V6.4.2
- Svo&lt;SvoBehavior&gt; and Id&lt;IdBehavior&gt; decorated with IEqualityOperators. #315
v6.4.1
Expand Down
Loading