Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AggregateRoot to Aggregate #35

Merged
merged 12 commits into from
Jun 7, 2023
Merged

Rename AggregateRoot to Aggregate #35

merged 12 commits into from
Jun 7, 2023

Conversation

Corniel
Copy link
Contributor

@Corniel Corniel commented Jun 5, 2023

It is shorter, and as even DDD experts can not fully agree on the distinction, it is better this way.

@Corniel Corniel added enhancement New feature or request feature request labels Jun 5, 2023
@CptWesley
Copy link

You could consider keeping an AggregateRoot abstract class that extends Aggregate with a deprecation notice, so that you don't instantly kill all existing implementations.

@Corniel
Copy link
Contributor Author

Corniel commented Jun 6, 2023

You could consider keeping an AggregateRoot abstract class that extends Aggregate with a deprecation notice, so that you don't instantly kill all existing implementations.

You only have to rename, that should not be too hard, should it?

@CptWesley
Copy link

You could consider keeping an AggregateRoot abstract class that extends Aggregate with a deprecation notice, so that you don't instantly kill all existing implementations.

You only have to rename, that should not be too hard, should it?

I understand, but it might discourage people to upgrade

@Corniel
Copy link
Contributor Author

Corniel commented Jun 6, 2023

I understand, but it might discourage people to upgrade

Fair point to. I changed the behavior.

LauraXiulan
LauraXiulan reviewed Jun 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
LauraXiulan
LauraXiulan reviewed Jun 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
LauraXiulan
LauraXiulan reviewed Jun 6, 2023
View reviewed changes
README.md Show resolved Hide resolved
LauraXiulan
LauraXiulan reviewed Jun 6, 2023
View reviewed changes
README.md Show resolved Hide resolved
Corniel Nobel added 2 commits June 6, 2023 21:12
@Corniel Corniel merged commit 0eb58ba into master Jun 7, 2023
@Corniel Corniel deleted the aggregate branch June 7, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CptWesley CptWesley CptWesley approved these changes

@LauraXiulan LauraXiulan LauraXiulan approved these changes

@mars888 mars888 Awaiting requested review from mars888

@Sjaaky Sjaaky Awaiting requested review from Sjaaky

Assignees
No one assigned
Labels
enhancement New feature or request feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Corniel @CptWesley @LauraXiulan