Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Poker v14 #63

Merged
merged 1 commit into from
Jun 27, 2024
Merged

feat: Poker v14 #63

merged 1 commit into from
Jun 27, 2024

Conversation

wackfx
Copy link
Contributor

@wackfx wackfx commented Jun 24, 2024

Demo video

https://www.loom.com/share/3ad66570f6e04c93a642aca8f0da6e3d?sid=9416774d-8cd7-4c62-9285-fce3e69b06fb

Features

  • All original features with various edge cases tested (quitting in middle of a game, joining a game running, ending game abruptly ...)
  • Added a GamePokeCombination logic to actually tell who won
  • Configurable rewards
  • Now Kepler is really fully v14 feature complete 😄

Reviewers note

  • I had to change the ITEMMSG because some Poker commands don't correctly stops when there is a trailling {13}
  • I added bonuses. The original implementation is pretty boring. It's configurable, and well isolated so it can be removed easily if you want (remove GamePokerOptions, 2 calls, + options)
  • We could improve the GamePokeCombination to actually further discriminate winner (when there is tie) depending on the value of the cards. I didn't bother going that far because I thought that having this simpler mechanic is cool for this game.

Patches #42

@manuserranog
Copy link

How did you run the Shockwave client on Mac?

@wackfx
Copy link
Contributor Author

wackfx commented Jun 24, 2024

@manuserranog

You can run the game by using Adobe Director Projectors (archive.org) and Wineskin Winery (github.com) on macOS.

It requires some tampering but eventually it works.

import java.util.stream.Collectors;

public enum GamePokerCombination {
FIVE_OF_A_KIND("a Five of a kind"),
Copy link
Contributor Author

@wackfx wackfx Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change this to have proper texts using any tooling present in the code. This is not really great (TBH I thought that I would remove it before sending this PR / keep this for my code; as original version doesn't include this).

@Quackster
Copy link
Owner

Looks fine to me, thank you so much, this is fantastic. I will look into merging it after work etc.

@ThisAccountHasBeenSuspended

Great job! Looks good to me!

@Quackster Quackster changed the base branch from master to poker June 27, 2024 00:43
@Quackster
Copy link
Owner

I will merge into a different branch for now, make some small changes (which includes adding credits to you) and then merge it to master shortly where I will release a new build. :)

@Quackster Quackster merged commit 2dec8de into Quackster:poker Jun 27, 2024
@wackfx wackfx deleted the game-poker branch July 20, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants