-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Poker v14 #63
feat: Poker v14 #63
Conversation
How did you run the Shockwave client on Mac? |
You can run the game by using Adobe Director Projectors (archive.org) and Wineskin Winery (github.com) on macOS. It requires some tampering but eventually it works. |
import java.util.stream.Collectors; | ||
|
||
public enum GamePokerCombination { | ||
FIVE_OF_A_KIND("a Five of a kind"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change this to have proper texts using any tooling present in the code. This is not really great (TBH I thought that I would remove it before sending this PR / keep this for my code; as original version doesn't include this).
Looks fine to me, thank you so much, this is fantastic. I will look into merging it after work etc. |
Great job! Looks good to me! |
I will merge into a different branch for now, make some small changes (which includes adding credits to you) and then merge it to master shortly where I will release a new build. :) |
Demo video
https://www.loom.com/share/3ad66570f6e04c93a642aca8f0da6e3d?sid=9416774d-8cd7-4c62-9285-fce3e69b06fb
Features
Reviewers note
ITEMMSG
because some Poker commands don't correctly stops when there is a trailling {13}Patches #42