-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Добавление отчета по стирке #497
base: release/2.8
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12233567 | Triggered | Generic Password | 565d8df | Workwear/Reports/ClothingServiceReport.rdl | View secret |
12233567 | Triggered | Generic Password | b853d6b | Workwear/Reports/ClothingServiceReport.rdl | View secret |
12233567 | Triggered | Generic Password | b853d6b | Workwear/Reports/ClothingServiceReport.rdl | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Столбец "Закрыта" скрыт в случае закрытых заявок, формат столбца исправлен с +/- на да/нет
using Workwear.ReportParameters.ViewModels; | ||
|
||
namespace Workwear.ReportParameters.Views { | ||
[System.ComponentModel.ToolboxItem(true)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Эту строчку можно убрать. Она не нужна
<Left>10pt</Left> | ||
<Height>12pt</Height> | ||
<Width>3in</Width> | ||
<Value>=Globals!PageNumber + ' of ' + Globals!TotalPages</Value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут можно по русски "из"
var parameters = new Dictionary<string, object>(); | ||
using (var unitOfWork = UnitOfWorkFactory.CreateWithoutRoot()) { | ||
var sizes = sizeService.GetSizeType(unitOfWork, onlyUseInEmployee: true).Take(6).ToList(); | ||
parameters.Add($"show_closed", showClosed); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем здесь $?
public class ClothingServiceReportViewModel: ReportParametersViewModelBase { | ||
private readonly SizeService sizeService; | ||
|
||
public ClothingServiceReportViewModel(RdlViewerViewModel rdlViewerViewModel, SizeService sizeService) : base(rdlViewerViewModel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Как тут используется сервис размеров? Помоему это мусор.
return parameters; | ||
} | ||
|
||
private bool showClosed = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я бы лучше добавил диапазон дат, если галочка поставлена. Ну типо вариант только текущие. Или все за период. Ибо получать весть список за все время как будто бы никому не надо.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну да, как и говорили, сделать поле с датой в фильтре, чтотбы когда показываются закрытые можно было снизу список обрезать.
И еще надо скрывать этот пункт меню в той версии которая не поддерживает стирку. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Переключи окончания строк на crlf
CASE WHEN state = 'WaitService' THEN | ||
'В ожидании' | ||
WHEN state = 'InReceiptTerminal' THEN | ||
'Принят терминалом' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Думаю, лучше "В терминале приёма" как буд-то будет очевидее работнику сервиса.
return parameters; | ||
} | ||
|
||
private bool showClosed = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну да, как и говорили, сделать поле с датой в фильтре, чтотбы когда показываются закрытые можно было снизу список обрезать.
No description provided.