Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overriding metaclass. #61

Closed
wants to merge 1 commit into from
Closed

Add overriding metaclass. #61

wants to merge 1 commit into from

Conversation

hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi force-pushed the overriding_metaclass branch 2 times, most recently from 406b2fd to f757534 Compare June 25, 2020 11:35
@peterbell10
Copy link
Collaborator

You seem to have commit a binary file by accident. I assume .profraw is some profiler output?

@hameerabbasi
Copy link
Collaborator Author

I assume .profraw is some profiler output?

It shows up with a simple pytest, I'm not entirely clear on why.

hameerabbasi
hameerabbasi commented Jul 2, 2020
View reviewed changes
unumpy/numpy_backend.py
@@ -11,30 +11,44 @@
__ua_domain__ = "numpy"


def overridden_class(self):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaosferreira For Dask, this would have an additional:

if self is np.ndarray:
    return da.Array

This was referenced Jul 20, 2020
Merged
Merged
@hameerabbasi
Copy link
Collaborator Author

Superceded by #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbell10 peterbell10 Awaiting requested review from peterbell10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hameerabbasi @peterbell10