Multimethods for functional programming routines #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaosferreira
changed the title
|
I'm wondering if the items in |
|
The default for |
| def _piecewise_default(x, condlist, funclist, *args, **kw): | ||
| if not isinstance(condlist, list): | ||
| condlist = [condlist] | ||
|
|
There was a problem hiding this comment.
Suggested change
| condlist = [asarray(cond) for cond in condlist] | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multimethods that target functional programming routines. The multimethods are the following:
apply_along_axisapply_over_axesfrompyfuncpiecewiseNotes:
vectorizewhich is actually a class so it needs to wait for Add overriding metaclass. #61 to be done and its changes are merged before it can be added.onp.ufuncandda.ufunc.ufuncto the possible returned types in the tests. These are needed for testing the returned type offrompyfunc.