Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2023-01-25 #636

Merged
merged 20 commits into from
Jan 26, 2023
Merged

Release 2023-01-25 #636

merged 20 commits into from
Jan 26, 2023

Conversation

noatamir
Copy link
Contributor

Merge develop into main

ImgBotApp and others added 20 commits January 17, 2023 20:26
@ImgBotApp
[ImgBot] Optimize images
6f9fbe9 
*Total -- 583.05kb -> 453.44kb (22.23%)

/apps/labs/public/posts/python-packaging-where-to-next/unified_workflow_tool.png -- 213.90kb -> 92.99kb (56.53%)
/apps/labs/public/posts/reproducible-builds/ipython_logo.png -- 9.00kb -> 6.98kb (22.42%)
/apps/labs/public/posts/reproducible-builds/blog_hero_org.svg -- 51.99kb -> 50.69kb (2.49%)
/apps/labs/public/posts/designing-with-and-for-developers/blog_hero_var1.svg -- 51.76kb -> 50.49kb (2.47%)
/apps/labs/public/posts/python-packaging-where-to-next/team_hero.svg -- 87.11kb -> 85.36kb (2.01%)
/apps/labs/public/posts/designing-with-and-for-developers/blog_feature_var1.svg -- 84.65kb -> 83.45kb (1.42%)
/apps/labs/public/posts/reproducible-builds/blog_feature_var2.svg -- 84.65kb -> 83.49kb (1.37%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
@trallard
Merge pull request #629 from Quansight/imgbot
97eb7ae 
[ImgBot] Optimize images
@MarsBarLee @noatamir
[BLOG] Add labs-status-update-may (#553)
02f4eb7 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@MarsBarLee
[BLOG] Add quansight-at-scipy2019 (#550)
0b014ed
@MarsBarLee
[BLOG] Add labs-dask-update (#549)
7dd70ce
@MarsBarLee
[BLOG] Add whats-new-in-sympy-14 (#609)
bc88a32
@MarsBarLee @noatamir
[BLOG] Add joining_labs (#610)
1296999 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@MarsBarLee @noatamir
[BLOG] Add spyder-40-beta4-kite-integration-is-here (#548)
83bb50f 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@MarsBarLee @noatamir
[BLOG] Add quansight-labs-work-update-for-september-2019 (#546)
a3e6f12 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@MarsBarLee
[BLOG] Add files-improvements (#545)
ce117fe
@MarsBarLee @noatamir
[BLOG] Add uarray-attempting-to-move-the-ecosystem-forward (#543)
2bb2a64 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@MarsBarLee
[BLOG] Add tdk-partners-with-quansight-labs (#551)
485d83f
@MarsBarLee
Community opensource funded development (#511)
dbbc13c
@MarsBarLee @noatamir
[BLOG] Add pytorch-tensoriterator-internals-update (#510)
487573b 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@MarsBarLee @noatamir
[BLOG] Add introducing-code-generator-v020 (#512)
da81c6d 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@MarsBarLee @noatamir
[BLOG] Add not-a-checklist (#514)
719064b 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@MarsBarLee
[BLOG] Add spyder4-variable-explorer (#513)
2c6b0d1
@MarsBarLee @noatamir
[BLOG] Add low-code-workshop (#515)
f8057db 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@MarsBarLee @noatamir
[BLOG] Add a-step-towards-educating-with-spyder (#518)
a9ddc32 
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@noatamir
fix category in two blogs (#635)
18ee436
@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
consulting ✅ Ready (Inspect) Visit Preview Jan 25, 2023 at 2:53PM (UTC)
labs ✅ Ready (Inspect) Visit Preview Jan 25, 2023 at 2:53PM (UTC)

@gabalafou
Copy link
Contributor

I scanned the pages at the following blog slugs ever so briefly:

Nothing popped out at me on those pages, other than some missing avatars, which is to be expected I think. (Although our default no-avatar icons could be improved, I think; something is off, they don't look right to me, they look glitchy-like.)

A few other things I noticed:

  • One of the blog slugs uses an underscore rather than a hyphen: joining_labs
  • One of the blog slugs uses a capital letter (note that our URLs are case sensitive): Spyder4-variable-explorer
  • Some of the blog slugs (files-improvements) are more generic than I would like

gabalafou
gabalafou approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@gabalafou gabalafou left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't think any of those things should prevent the release, hence the approve.

@bskinn
Copy link
Contributor

bskinn commented Jan 26, 2023

A few other things I noticed:

  • One of the blog slugs uses an underscore rather than a hyphen: joining_labs
  • One of the blog slugs uses a capital letter (note that our URLs are case sensitive): Spyder4-variable-explorer
  • Some of the blog slugs (files-improvements) are more generic than I would like

If we change these, we will want to add redirects from these old slugs to the new versions, to avoid breaking inbound links.

@noatamir
Copy link
Contributor Author

Thanks @gabalafou and @bskinn! 🌷
I believe so far the blog slugs were kept the same as they were pre-migration. But I like this suggestion.
I'm merging the release and will start reviewing the blog slugs with this in mind for the next migration batch.

CC @MarsBarLee @pavithraes for transparency on review change. I will open an issue for these fixes and redirects, but it's not urgent.

@noatamir noatamir merged commit 71785f1 into main Jan 26, 2023
@noatamir noatamir deleted the release-23-01-25 branch January 26, 2023 08:43
@noatamir noatamir mentioned this pull request Jan 26, 2023
Open
@gabalafou
Copy link
Contributor

If we change these, we will want to add redirects from these old slugs to the new versions, to avoid breaking inbound links.

But... haven't we already broken the old links by doing away with the /year/month scheme? For example:

@bskinn
Copy link
Contributor

bskinn commented Jan 26, 2023

But... haven't we already broken the old links by doing away with the /year/month scheme?

Indeed, never mind! I hadn't realized Labs blog had changed slug scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabalafou gabalafou gabalafou approved these changes

@trallard trallard Awaiting requested review from trallard trallard is a code owner

@rgommers rgommers Awaiting requested review from rgommers rgommers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@noatamir @gabalafou @bskinn @ImgBotApp @trallard @MarsBarLee