Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOG] Add whats-new-in-sympy-14 #609

Merged
merged 7 commits into from
Jan 20, 2023
Merged

[BLOG] Add whats-new-in-sympy-14 #609

merged 7 commits into from
Jan 20, 2023

Conversation

MarsBarLee
Copy link
Contributor

Link to blog post, successful build.

Links to other Quansight blogs:

There is no need to check for Blog2Blog links due to updated website build.

Text styling

  • The blog is written with plain language (where relevant).
  • If there are headers, they use the proper header tags in order to do so (with only one level-one header).
  • All links describe where they link to (for example, check the Quansight labs website).
  • Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

  • All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing gifs or videos.
  • If it were to be read as plain text, the blog still makes sense and no information is missing.

@vercel
Copy link

vercel bot commented Dec 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
consulting ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 6:52PM (UTC)
labs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 6:52PM (UTC)

@MarsBarLee
Copy link
Contributor Author

@gabalafou The Vercel build error shows a prerendering error and ReferenceError:

Error occurred prerendering page "/blog/whats-new-in-sympy-14". Read more: https://nextjs.org/docs/messages/prerender-error
ReferenceError: n is not defined
at _createMdxContent (eval at <anonymous> (file:///vercel/path0/node_modules/next-mdx-remote/dist/index.js:55:35), <anonymous>:815:47)
at MDXContent (eval at <anonymous> (file:///vercel/path0/node_modules/next-mdx-remote/dist/index.js:55:35), <anonymous>:974:9)
...

(Link to Vercel build error)

I think this error is related to the math used in the blog post. Maybe due to the <math> tag or pycon in the code blocks?

@MarsBarLee MarsBarLee marked this pull request as ready for review January 2, 2023 19:17
@gabalafou
Copy link
Contributor

gabalafou commented Jan 20, 2023

Hey @MarsBarLee, I pushed a commit to this branch that I think fixes the build issues. If it builds this time, can you double check the post? If it looks good on your end, I can go ahead and approve and squash-merge this PR into develop.

Copy link
Contributor

@noatamir noatamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabalafou
Copy link
Contributor

@noatamir since it looks good to you, I'm going to go ahead and merge this is in.

@gabalafou gabalafou merged commit bc88a32 into develop Jan 20, 2023
@gabalafou gabalafou deleted the whats-new-in-sympy-14 branch January 20, 2023 21:21
gabalafou pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labs 🔭 Items related to the Labs website type: content 📝
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants