Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mypy after pydantic 2.7 #390

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix mypy after pydantic 2.7 #390

merged 1 commit into from
Apr 16, 2024

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Apr 15, 2024

After the pydantic 2.7 release (April 11 2024), which gets installed in CI since we only have a lower pin

ragna/pyproject.toml

Lines 31 to 33 in f7de2e9

"pydantic>=2",
"pydantic-core",
"pydantic-settings>=2",

a few typing errors popped up, e.g. https://github.com/Quansight/ragna/actions/runs/8676481873/job/23791035320?pr=389. It seems typing on these objects was made a little tighter and now we have to ignore more dynamic stuff. Fortunately, no functional changes.

@pmeier pmeier added the type: maintenance 🛠️ Day-to-day maintenance tasks label Apr 15, 2024
@pmeier pmeier requested a review from nenb April 15, 2024 07:01
@pmeier pmeier merged commit 0fbe8c0 into main Apr 16, 2024
10 checks passed
@pmeier pmeier deleted the mypy branch April 16, 2024 16:42
pmeier added a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance 🛠️ Day-to-day maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants