Conversation
This was referenced Apr 15, 2024
Merged
nenb
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the pydantic 2.7 release (April 11 2024), which gets installed in CI since we only have a lower pin
ragna/pyproject.toml
Lines 31 to 33 in f7de2e9
a few typing errors popped up, e.g. https://github.com/Quansight/ragna/actions/runs/8676481873/job/23791035320?pr=389. It seems typing on these objects was made a little tighter and now we have to ignore more dynamic stuff. Fortunately, no functional changes.