Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mosaic Assistant #387

Conversation

smokestacklightnin
Copy link
Contributor

This PR addresses Issue #385.

Mosaic ML seems to have removed or deprecated their REST API. As a result, including this assistant was causing tests to fail (see the attached issue).

It is not necessary to support deprecated APIs, so this PR removes it from Ragna.

@smokestacklightnin smokestacklightnin changed the title Remove Mosaic Remove Mosaic Assistant Apr 12, 2024
@smokestacklightnin smokestacklightnin linked an issue Apr 12, 2024 that may be closed by this pull request
@smokestacklightnin
Copy link
Contributor Author

The typing linter seems to fail on GitHub but passes locally for me. I am skeptical that the failure has anything to do with the changes in this PR

@smokestacklightnin smokestacklightnin added type: maintenance 🛠️ Day-to-day maintenance tasks and removed type: bug 🐛 Something isn't working labels Apr 12, 2024
@pmeier
Copy link
Member

pmeier commented Apr 15, 2024

The typing linter seems to fail on GitHub but passes locally for me. I am skeptical that the failure has anything to do with the changes in this PR

It has not. See #390.

I'm waiting for one other confirmation that the API is indeed gone. If I have that, the PR is good to go.

@pmeier pmeier merged commit 3a5b82d into Quansight:main Apr 24, 2024
9 of 10 checks passed
pierrotsmnrd added a commit that referenced this pull request May 13, 2024
commit 04168ab
Author: Arjun Verma <arjunverma.oc@gmail.com>
Date:   Wed May 1 12:35:41 2024 +0530

    #373 Include documentation_helpers in module (#395)

    Co-authored-by: Philip Meier <github.pmeier@posteo.de>

commit f947f2d
Author: Philip Meier <github.pmeier@posteo.de>
Date:   Mon Apr 29 17:08:40 2024 +0200

    bump mypy to 1.10 (#398)

commit e0fe014
Author: Kevin Klein <7267523+kklein@users.noreply.github.com>
Date:   Mon Apr 29 12:52:49 2024 +0200

    Add instructions to install from conda-forge. (#396)

    Co-authored-by: Philip Meier <github.pmeier@posteo.de>

commit 7963453
Author: Philip Meier <github.pmeier@posteo.de>
Date:   Thu Apr 25 20:38:50 2024 +0200

    use custom JSON type for database for more generic support (#389)

commit 3a5b82d
Author: William Black <125844868+smokestacklightnin@users.noreply.github.com>
Date:   Wed Apr 24 01:37:48 2024 -0700

    Remove Mosaic Assistant (#387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MosaicML API is either down or removed
2 participants