changed QuantConnect.IBAutomater.csproj to SDK style #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vslee
commented
May 11, 2020
•
vslee
commented
- it was previously MSBuild style
- this changes it to the newer SDK style, which will allow further options in the future
- SDK style is more concise: a lot of settings which were explicitly specified before are now the defaults
- App.Config, packages.config, and AssemblyInfo.cs were able to be removed as their information is now in QuantConnect.IBAutomater.csproj
- functional settings have been preserved, including targeting .net framework 4.5.2
- versions of dependencies such as Newtonsoft.Json 10.0.3 and NodaTime 1.3.4 have been preserved
- NuGet settings have not been touched
- CSharpDemoIBAutomater remains as a MSBuild style project targeting .net framework 4.5.2 to show that this does not break current projects
- part of Multi-targeting (NET Standard 2.0 + NET Framework 4.5) #15
- it was previously MSBuild style - this changes it to the newer SDK style, which will allow further options in the future - SDK style is more concise: a lot of settings which were explicitly specified before are now the defaults - functional settings have been preserved, including targeting .net framework 4.5.2, as well as Newtonsoft.Json 10.0.3 - App.Config, packages.config, and AssemblyInfo.cs were able to be removed as their information is now in QuantConnect.IBAutomater.csproj - NuGet settings have not been touched - part of QuantConnect#15
- solves all current merge conflicts
|
rebased to master, solving merge conflicts |
|
HI @vslee! Welcome! Thanks for the PR we'll review and try and get it merged today. |
StefanoRaggi
suggested changes
Sep 15, 2020
There was a problem hiding this comment.
Thank you for the PR @vslee
I just tested the changes and pushed v1.0.30 to NuGet
Just a few minor changes requested:
- remove the
Propertiesfolder from the project file - update the demo project to reference the latest NuGet package (v1.0.30)
- update
QuantConnect.IBAutomater.nuspecfor the new build output path:
these are the updated lines:
<version>1.0.30</version>
...
<file src="net452\QuantConnect.IBAutomater.exe" target="lib\net45" />
<file src="net452\QuantConnect.IBAutomater.pdb" target="lib\net45" />
...
<file src="net452\IBAutomater.bat" target="build" />
<file src="net452\IBAutomater.sh" target="build" />
Comment on lines
19
to
21
| <ItemGroup> | ||
| <Folder Include="Properties\" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
I think we can safely remove these lines
StefanoRaggi
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.