Fix main window detection with IBGateway v978 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tested with both v974 and v978
StefanoRaggi
added a commit
to QuantConnect/Lean
that referenced
this pull request
Jun 22, 2020
StefanoRaggi
added a commit
to QuantConnect/Lean
that referenced
this pull request
Jun 25, 2020
Martin-Molinero
approved these changes
Jun 25, 2020
9 tasks
The main window might not be completely initialized when the "Starting application" splash window is closed so we start a task and wait 5 seconds maximum for the window to be ready.
StefanoRaggi
added a commit
to QuantConnect/Lean
that referenced
this pull request
Jun 26, 2020
StefanoRaggi
added a commit
to QuantConnect/Lean
that referenced
this pull request
Jul 2, 2020
StefanoRaggi
added a commit
to QuantConnect/Lean
that referenced
this pull request
Jul 2, 2020
Martin-Molinero
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main window was occasionally not detected properly, causing initialization failure (with IBGateway v978).
A previous fix for this issue was merged in #13, but it was still possible to consistently repeat the issue.
With IBGateway v978 apparently something changed in the initial loading of the windows which made our current logic unreliable.
This is the failing case:
the main window is set here:
https://github.com/QuantConnect/IBAutomater/pull/18/files#diff-f99616d61473f68c66c3e17455eb4339L227
but this line returns null:
https://github.com/QuantConnect/IBAutomater/pull/18/files#diff-f99616d61473f68c66c3e17455eb4339L261
With the new simplified logic, the main window detection is all done in a single method and this check is now always returning true:
https://github.com/QuantConnect/IBAutomater/pull/18/files#diff-f99616d61473f68c66c3e17455eb4339R230