generated from QuantConnect/Lean.Brokerages.Template
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combo orders #54
Merged
Martin-Molinero
merged 13 commits into
QuantConnect:master
from
jhonabreul:feature-combo-orders
Jan 6, 2023
Merged
Combo orders #54
Martin-Molinero
merged 13 commits into
QuantConnect:master
from
jhonabreul:feature-combo-orders
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for IB combo orders. Added unit tests
…for tracking combo fills timeout
jhonabreul
force-pushed
the
feature-combo-orders
branch
from
December 30, 2022 22:19
58a1b13
to
0b845de
Compare
Also waiting on events only when queue is empty
jaredbroad
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review in slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Base implementation for submitting and handling combination or multi-legged orders.
Note on fill events: the brokerage will wait for all fills in the group before emitting the fill events to Lean in the same batch, unless we timeout (30 seconds by default), in which case a batch of events with the fills we have up until that moment will be emitted to Lean.
Related Issue
Closes #8
Motivation and Context
Requires Documentation Change
How Has This Been Tested?
Unit tests and end-to-end tests.
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>