Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combo orders #54

Merged
merged 13 commits into from
Jan 6, 2023
Merged

Conversation

jhonabreul
Copy link
Collaborator

@jhonabreul jhonabreul commented Dec 30, 2022

Description

Base implementation for submitting and handling combination or multi-legged orders.

Note on fill events: the brokerage will wait for all fills in the group before emitting the fill events to Lean in the same batch, unless we timeout (30 seconds by default), in which case a batch of events with the fills we have up until that moment will be emitted to Lean.

Related Issue

Closes #8

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

Unit tests and end-to-end tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@jaredbroad jaredbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review in slack

@Martin-Molinero Martin-Molinero merged commit b95751d into QuantConnect:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Combo Orders
3 participants