Skip to content

Commit

Permalink
Fixes AwesomeOscillator Helper Order Of Parameters (#8099)
Browse files Browse the repository at this point in the history
The second and third parameter are `fastPeriod` and `slowPeriod`, but we had `slowPeriod` and `fastPeriod`, which is inconsistent with the class contructor and other indicators with `fastPeriod` and `slowPeriod` parameters.
  • Loading branch information
AlexCatarino committed Jun 25, 2024
1 parent 5699fa4 commit 9e2b697
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Algorithm/QCAlgorithm.Indicators.cs
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public AverageDirectionalIndex ADX(Symbol symbol, int period, Resolution? resolu
/// <param name="type">The type of moving average used when computing the fast and slow term. Defaults to simple moving average.</param>
/// <param name="selector">Selects a value from the BaseData to send into the indicator, if null defaults to casting the input value to a TradeBar</param>
[DocumentationAttribute(Indicators)]
public AwesomeOscillator AO(Symbol symbol, int slowPeriod, int fastPeriod, MovingAverageType type, Resolution? resolution = null, Func<IBaseData, IBaseDataBar> selector = null)
public AwesomeOscillator AO(Symbol symbol, int fastPeriod, int slowPeriod, MovingAverageType type, Resolution? resolution = null, Func<IBaseData, IBaseDataBar> selector = null)
{
var name = CreateIndicatorName(symbol, $"AO({fastPeriod},{slowPeriod},{type})", resolution);
var awesomeOscillator = new AwesomeOscillator(name, fastPeriod, slowPeriod, type);
Expand Down

0 comments on commit 9e2b697

Please sign in to comment.