Fixes AwesomeOscillator Helper Order Of Parameters #8099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The second and third parameters are
fastPeriod
andslowPeriod,
but we hadslowPeriod
andfastPeriod,
which is inconsistent with the class constructor and other indicators withfastPeriod
andslowPeriod
parameters.Related Issue
N/A
Motivation and Context
Consistency and documentation.
Other platforms follow this conversion:
short and long, which is fast and slow respectively
https://qtpylib.io/docs/latest/indicators.html#awesome-oscillator
Requires Documentation Change
No: code gen.
How Has This Been Tested?
N/A
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>