Acceleration bands #1099
Merged
Acceleration bands #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 29, 2017 11:39
Indicators/AccelerationBands.cs
Outdated
| LowerBand.Update(new IndicatorDataPoint | ||
| { | ||
| Time = input.Time, | ||
| Value = input.Low * (1 - _width * (input.High - input.Low) / (input.High + input.Low)) |
There was a problem hiding this comment.
Since you are using _"width * (input.High - input.Low) / (input.High + input.Low)" twice you might assign it to some var en line 100
| delta: 1e-4, message: "Upper band test fail.") | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
missing MiddleBand test?
There was a problem hiding this comment.
Please check the ´CommonIndicatorTests´ class.
| /// <summary> | ||
| /// Gets the lower acceleration band (Low * (1 - Width * (High - Low)/ (High + Low))) | ||
| /// </summary> | ||
| public IndicatorBase<IndicatorDataPoint> LowerBand { get; } |
There was a problem hiding this comment.
all of these could be readonly?
jaredbroad
approved these changes
Aug 30, 2017
|
Nice work @Jay-Jay-D, thanks for the review @MartinMoli ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the Acceleration bands. #1066