Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alpaca Brokerage updates (part 2) #4601

Merged
merged 5 commits into from
Sep 9, 2020
Merged

Alpaca Brokerage updates (part 2) #4601

merged 5 commits into from
Sep 9, 2020

Conversation

StefanoRaggi
Copy link
Contributor

@StefanoRaggi StefanoRaggi commented Jul 30, 2020 •
edited
Loading

Description

  • Fixes WebSocket connect sequence which was not waiting for completion
  • Removed the IDataQueueHandler implementation (Polygon.io streaming) from the AlpacaBrokerage
    (the PolygonDataQueueHandler is now available: Add PolygonDataQueueHandler #4604)

Related Issue

n/a

Motivation and Context

Live trading stability.

Requires Documentation Change

No.

How Has This Been Tested?

  • Tested locally and in QC cloud

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@StefanoRaggi StefanoRaggi force-pushed the alpaca-brokerage-updates-2 branch 2 times, most recently from e824236 to aaf5b9a Compare August 3, 2020 13:08
Martin-Molinero
Martin-Molinero reviewed Aug 29, 2020
View reviewed changes
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup PR! 👍 leaving a couple of concerns

Brokerages/Alpaca/AlpacaBrokerage.cs Show resolved Hide resolved
Brokerages/Alpaca/AlpacaBrokerageFactory.cs Show resolved Hide resolved
@Martin-Molinero Martin-Molinero merged commit 8785af7 into master Sep 9, 2020
@StefanoRaggi StefanoRaggi deleted the alpaca-brokerage-updates-2 branch September 9, 2020 18:18
@C-SELLERS C-SELLERS mentioned this pull request Nov 24, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwigginton joshwigginton joshwigginton approved these changes

@Martin-Molinero Martin-Molinero Martin-Molinero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanoRaggi @joshwigginton @Martin-Molinero