Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CoarseFundamental tests assertion #5138

Merged

Conversation

AdalyatNazirov
Copy link
Contributor

Description

Use CultureInfo.InvariantCulture to represent numbers in test assert expression.

Related Issue

N/A

Motivation and Context

CoarseFundamentalTests fails for non US English cultures (tested for ru-RU)

image

Requires Documentation Change

N/A

How Has This Been Tested?

Existing unit tests pass (before fail)

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

…eparator for non-US English cultures, but expected dot
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Martin-Molinero Martin-Molinero merged commit 8d48996 into QuantConnect:master Jan 7, 2021
@AdalyatNazirov AdalyatNazirov deleted the fix-decimal-conversion branch January 7, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants