BrokerageAuthentication Classes #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 935c037.
| /// Validate Brokerage Authentication Parameters | ||
| /// </summary> | ||
| /// <returns>true for OK (ie. no error)</returns> | ||
| public abstract bool Validate(); |
There was a problem hiding this comment.
We may need a way of communicating what failed validation. We could possible have this return a ValidationResult instance instead of just true/false.
|
Request cancelled (to the replaced). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed last week, attempt #2 at building brokerage authentication code.
Note the initial seting of a values in OandaBrokerageAuthentication method; I'm assuming that we could display these on a drop-box in the web UI (instead of having the user enter the URL).
I'm aware that I haven't set intial values for the Oanda API anywhere yet.