Reuse Code To Find Best Effort TradeBar

[AlexCatarino]

Description

The LimitFill, LimitIfTouchedFill, and StopMaketFill methods require TradeBar data to test price levels. We create a method to serve these methods as well as other methods that will require this information.

Removes Price > 0 check for TradeType.Trade data. Unnecessary check, since a tick price cannot be less or equal to zero.

Related Issue

See #7042

Motivation and Context

Code reuse avoids bugs.

How Has This Been Tested?

N/A refactor. All unit tests have passed. We need to fix Limit fill tests that were not using market data types (not valid subscriptions) to set the price.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Refactor (non-breaking change which improves implementation)
• Performance (non-breaking change which improves performance. Please add associated performance test and results)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Non-functional change (xml comments/documentation/etc)

Checklist:

• My code follows the code style of this project.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

[Martin-Molinero]

Nice!